Andrea Aime wrote: > Hi, > > just yesterday I stumbled on an inconsistency between the > geometry filters implementations and the sql pre/post splitter > in 2.2.x (and maybe in 2.3.x, unless someone fixed this). > > The geom filter implementation turns null expressions into > default geometries, but the pre/post splitter > (PostPreProcessFilterSplittingVisitor, what a name :-) ) > states a geometry filter with null left/right expressions > cannot be encoded (which means the filter will have to > run in memory, so much for your bbox filter that becomes > totally useless from a performance point of view). > > Yet, this does not surprise me much: the GeometryFilter > behaviour is coded in the implementation, but I could not > find it cited anywhere in the javadocs. > > So, there is a bug, but I'm not sure if it's in the spec > or in the splitter... all in know is that WFS GetFeature > requests that do use bbox filters are hellish slow in > Geoserver because of this... > splitter > Opinions? > Questions: - Can we simply represent this as Expression.NULL and expect the SQL generator to generate the right thing? - Can we confirm what the filter specification expects of us? ie - check default geometry or check all geometry.
If we can get away with just using the default geometry their are two options: Option#1: Add a preprocessing step where we go through the filter and take all spatial operators that are Expression.NULL and which turns them into a reference to the named default geometry. Option#2: Leave it represented as NULL and the splitter and generator to actually obey the same contract (they are a matched set) If we need to check all: - Leave it represened as NULL and fix the SQL generator + splitter Bleah; Jody ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
