It was intended to be a code demo; but it does *work* - as such it was the only GeoTools DataStore I could use over the summer to email data around with more then one Geometry !!!
If you need this one to be supported I will be happy to do so; the other reason to have it be in demo/ is so it can be more of a public domain starting place for people to fork off their own datastore implementation. Jody > Fair enough, if the point of this datastore is to be a code demo then I > should probably not be using it for such a reason. > > Jody Garnett wrote: > >> So if I read the patch correct ... two things are done.... >> >> 1) replaced a attType instanceof GeometryAttributeType check with a call >> to "Converters" >> >> + return Converters.convert( stringValue, attType.getType()); >> > Could do, then that means having the entire library use the Converter > api, i am sure that will pop up a few problems. > >> This line should go; attType.parse( Object ) is supposed to delegate to >> Converters behind the scenes - I do not >> want to explain about converters in the middle of this tutorial (especially >> when a method exists right there that >> is documented to do the right thing). >> >> Can we fix AttributeType.parse implementation (or perhaps this is already >> done?) If it cannot be fixed then direct use of >> Converters will be okay. >> >> It is too bad I wanted to show implementors how to handle a >> GeometryAttributeType - and your magic class is doing all >> the work behind the scenes for them. >> >> 2) preprocessed the text representation to trim off whitespace >> >> In terms of trimming whitespace, specifically for the PropertyDataStore this >> should not be needed, ie this ability allows users >> to provide whitespace ... so my question has to be why was this trim() >> needed? We are not using fixed length records or anything. >> >> > A couple of problems. The first being that it puts burden on the person > writing the property file to make sure that strings do not contain any > extra whitespace. > > The second being that what if you want to provide a null value as the > last property. As written you would write an entry like: > > someFeature=someValue1|someValue2| > > When split is called you will only get two values and not three so the > reader will throw an exception. Perhaps a better way to fix would be to > have the reader check for this case and just assume the final value is null. > > -Justin > > >> Cheers, >> Jody >> PS. I do need to update the tutorial which this class is the source code for >> :-( >> >> >> >>> Hi Jody, >>> >>> I have submitted a little patch for PropertyAttributeReader. It came out >>> of using the datastore as a basis for mock geoserver tests. Using this >>> datastore is nice and easy to create a complete mock instance of >>> geoserver ( catalog and all ) and fire requests against it without the >>> need for an actual running server. >>> >>> Anywho, the patch can be found here. Thanks. If you find it ok just say >>> the word and I can apply myself. >>> >>> http://jira.codehaus.org/browse/GEOT-1070 >>> >>> -Justin >>> >>> >>> >> ------------------------------------------------------------------------- >> Take Surveys. Earn Cash. Influence the Future of IT >> Join SourceForge.net's Techsay panel and you'll get the chance to share your >> opinions on IT & business topics through brief surveys - and earn cash >> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV >> _______________________________________________ >> Geotools-devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> >> !DSPAM:1004,4581ad60112742095110867! >> >> > > > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
