A side effect of how the transition was performed. The benefit was that we had a deprecation cycle so that everyone didn't have to shift immediately. The downside seems to be pain as we flush out where these things are still assuming the old interfaces.
I guess the short answer is that any filter that casts to an implementation class or interface is now wrong. -Justin Andrea Aime wrote: > Hi, > working on trunk is proving to be "fun" because of the > Geoapi filter mess. > Basically, we have an API that insists > on using Geoapi filters, and implementations that really do > want geotools filters instead. > Usually there's no difference, but too bad INCLUDE and EXCLUDE > are not geotools filters, so when you start using them you're > setting up for disaster. > > Silly example: > FilterFactory ff = ... > Filter newFilter = ff.and(Filter.INCLUDE, myOtherFilter); > > and then try to use newFilter in sql encoders, splitters and the > like and boom, class cast exceptions all over the place. > > Why? Well, you could argue that INCLUDE combined with everything > else should disappear, but the filter factory has no such > logic. I can fix the factory, but are we sure and/or/not are > they only ways include/exclude can be combined into a more > complex filter? I could create AndImpl before and then set > directly INCLUDE as one of the childs... > > Cheers > Andrea > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Geotools-devel mailing list > Geotools-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > !DSPAM:1004,45895684163881425493344! > -- Justin Deoliveira [EMAIL PROTECTED] The Open Planning Project http://topp.openplans.org ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
