Andrea Aime wrote: > Justin Deoliveira ha scritto: >> My instinct is to say use a builder or break out any other convenience >> methods. My reason being that geoapi is "supposed" to be toolkit >> agnostic. I think we should try to discourage from throwing in >> convenience methods on the interfaces themselves. > > Oh, since I keep getting funny class cast exception in the most strange > places (visitors) because I forget to turn fids (String) into FeatureId > when I build an id filter, would it be such a bad idea to have the > FidFilterImpl constructor check the contents of the set and turn every > string into a FeatureId? Hmm, not sure I agree with this one. Currently that is the filter implementation of Id, which can contain other types of identifiers: GmlObjectId, RecordId, etc... > It has already plenty of methods that do turn strings into fids, too > bad they're not visible past the geoapi FidFilter interface > > Cheers > Andrea > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Geotools-devel mailing list > Geotools-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > !DSPAM:1004,45951b3f273641425493344! >
-- Justin Deoliveira [EMAIL PROTECTED] The Open Planning Project http://topp.openplans.org ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
