Justin Deoliveira ha scritto: > Andrea Aime wrote: >> >> Justin, please, have a look at the changes I committed, and tell me >> which ones really needed a discussion. Have we to require permission >> for every trivial change we make? I did modify only the inner workings >> of a few classes. >> > The original point was not that the changes are in fact major. The point > is that your addressing performance in the wrong place in my opinion. > And by just committing without any discussion you are not really going > to fix your problem in the long term.
> What i mean is that if someone goes and writes another super slow > property accessor, and the factory spi system executes it before the one > you have optimized gets executed, all of your work is for nothing. All my work was prominently finding what went wrong, and writing the mails, doing the patches was a matter of minutes. You can revert them, but this means those users will be stuck again on a performance nightmare. We should be very glad they did write us with a full test to try out, others in their place may simply have concluded geotools is too slows and give up without notices... > And actually, there is a slow property accessor written that actually > fires up an entire JXPath context, and executes it against a feature, > which is a very expensive operation. This is going to be much much > slower than what you have just optimized. Ouch... scary, this means if the user puts the wrong jar in his lib folder he'll get the same issues? I think we should be doing good by default, that is, without requiring people to add hints, pay too much attention to the classpath, and so on... Cheers Andrea ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
