Hi Jody,
sorry for the delay, again. Life has been crazy last week.
A couple of questions;
- FeatGeomFactoryImpl is basically running as a small container specific
to the problem of producing Geometries. While I cannot see this *used*
anywhere in the codebase it is important to note that this is not a
Factory as it stands now... Shall I assume that the code you are using
this implementation with makes use of this class .. and treat the
problem as a feature request?
You are right, the FeatGeomFactoryImpl is not really a factory, as it only
saves the instances
for the Primitive/Complex/Coordinate/Aggregate factories. It also
encapsulates all the information
a geometric object may need to know such as the dimension or the precision
model, or the factory
instances.
The class is used, as all GM_Objects have a reference to the featGeomFactory
and use it to reach
such information (mentioned above).
- Assert - looks like you have a design decision to make here?
That class came with some code i used from the JTS. I was thinking about
replace it by an Exception,
but didn't had a proper solution in mind, and also little time left. So,
yes, the Asserts may should
maybe be replaced.
- DoubleOperation vs ExactDouble - if you need this kind of control it
is something we can do library wide
I original intention was to leave this opportunity only for metric
operations, such as length, area, distance,
since one may need precise results here. In contrast to constructive
operations such as intersection, union, etc.
Furthermore, i guess that using such elementary exact operations on
constructive operations would result in bad performace.
- org.geotools.geometry.iso.util.quadtree - sounds like you guys are
breaking out your own code for heavy lifting?
That is one of Jackson's packages. At the moment it is not used. I didn't
delete those packages since i didn't know if Jackson planned to do something
with them. Maybe Jackson can give us some more information about the further
use of those packages?
My other comment is that:
- the comments are verbose, plentiful and possibly duplicate the GeoAPI
documentation?
Yes, that is a part we need to "clean". They were just to help during the
developing time.
- While I can find a few non-english comments around at this statge
they tend to add spice.
The same thing. Hope to solve that together with Jackson soon, sorry!
- Headers, (c) and license are all topics for another day.
Ok, for know i added some LGPL headers as seen in other software. Didn't
know what exactly to write.
Regards,
Sanjay
More later :-)
Jody
--
Sanjay Jena
Eitorferstr. 5, 50679 Köln, Deutschland
Tel.: +49 221 7885099
Cel.: +49 163 1616196
--
Sanjay Jena
Eitorferstr. 5, 50679 Köln, Deutschland
Tel.: +49 221 7885099
Cel.: +49 163 1616196
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
