Asking around there was tones of stuff that SQLUnpacker did not do ...
talking to Jesse we cannot remember the details right now.
Jesse has been fixing the PostPreProcessing but could not do all the
simplification until he moves to trunk.
Yeah, 'tons of stuff', but when I asked for details all I got was the
theoretical filter thing which wasn't implemented. I backed down
because they had already done the work, but in general I think we should
start to get less accepting of new work unless it actually does
something significantly better, and that justification should be
provided. Hopefully the new policies will make this happen more. But I
do regret not being more forceful about making use of SQLUnpacker, since
it was one of the first pieces of code I wrote for GeoTools I thought
maybe it was lacking. But to be honest refactoring something that is
being used and keeping the interface around is much better than throwing
it out and writing something new. Indeed when the switch was made it
introduced new problems. GeoTools is going to languish just being used
by uDig and GeoServer until we figure out how to stick with an API, even
if there are improvements that can be made.
Chris
Looking at *both* these implementations I think they are an example of
code reuse getting in the way of clarity. It would be nice to have a
utility class that breaks down a Filter into just the part you can
encode, and then directly encode the good part into SQL with confidence.
I would find it much more clear to make a class that does this in one
pass; that is accepts a filter and outputs both an SQL statement and the
leftover filter that could not be encoded. That way we do not split up
decision making between two classes.
Cheers,
Jody
Farber, Saul (ENV) wrote:
This is kind of a targeted question, but I'll throw it out to the list to see
if anyone else can answer too.
Why is SQLUnpacker deprecated?
Looking at PostPreProcessFilterSplittingVisitor the only thing I can figure
that it's doing that SQLUnpacker isn't doing is handling client-side
transactions via a ClientTransactionAccessor.
Is there something fundamentally flawed about SQLUnpacker? I do have to say
that SQLUnpacker is MUCH more clearly and concisely written.
--saul
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
!DSPAM:1003,45f09751185341362196140!
--
Chris Holmes
The Open Planning Project
http://topp.openplans.org
begin:vcard
fn:Chris Holmes
n:Holmes;Chris
org:The Open Planning Project
adr:;;349 W. 12th Street, #3;New York;NY;10014;USA
email;internet:[EMAIL PROTECTED]
title:Managing Director, Strategic Development
x-mozilla-html:FALSE
url:http://topp.openplans.org
version:2.1
end:vcard
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
