Hi Martin: The implementation in unsupported/geometry is fine - it looks like it will handle any CoordinateReferenceSystem at the end of the day.
This is my first time in that code base (for some reason I thought you were keep tack of it? Or helping? or something ). The implementation (as mentioned in previous email over the last couple days) is simply new software that a few code reviews can put in order. The good news: - The implementation is not limited by 2D or 3D as far as DirectPositionImpl is concerned. The bad news :- The implementation is limited by a DimensionModel that you configure for each factory Near as I can tell DimensionModel is a stand in for the CoordinateReferenceSystem (which they were never able to use due to a maven problem - they only could have a CRS as null). The DimensionModel should be removed now, I have set things up so that referencing can be used when writing test cases. The other thing that jumped out at me was the manner in which the test cases were written - but that can be for another email. Jody > Since Jody is working on geometries, I have a little naming topic. Most > classes > in module/unsupported/geometry end with the "Impl" suffix. I wonder: what at > the > restriction in usage of this implementation, if any? For example: > > * Is module/unsupported/geometry implementation limited to the 2D case, or > is it nD? If it is limited to 2D, should we replace the "Impl" suffix > by a "2D" suffix? > > * Is module/unsupported/geometry implementation restricted to cartesian CS > or can it work with any CS? If it is restricted to cartesian CS, should > we replace the "Impl" suffix by something that suggests this rectriction? > (not sure which suffix; "Cartesian" is a little bit long). > > Martin > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys-and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Geotools-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
