Jody Garnett a écrit :
> In this case it is a blocker, the factory literally builds a list of
> AttributeTypes and then later creates a FeatureType from them ... it
> really is a builder rather then a factory.
Oups! I see. Then what about renaming "FeatureTypeFactory" as
"FeatureTypeBuilder"? And do we need a builder factory? I admit that it would
be
yet one more interface and indirection level...
>> In summary, explicit constructor argument means that any change in
>> arguments may cascade in many places because of dependencies, while a
>> single Hints argument cascade gently.
> Yep I get it ... this is the style of play that a container promotes as
> well. Basically making the coding experience more forgiving. My problem
> is more that we are doing this work at all (rather then about it working
> or not).
If a widely used container framework provides the same fonctionalities in a way
that doesn't require the installation of a whole JEE framework to get Geotools
working, we could drop the FactoryRegistry stuff and use the container
framework
instead. But having a working FactoryRegistry framework in the mean time help
to
reduce a little bit the pressure. I'm not against the removal (or reduction in
size) of the FactoryRegistry framework in long term, providing that:
- We get FactoryRegistry and different container frameworks to work together
(one possible approach: use constructor injection in Geotools factories,
and FactoryRegistry are used mostly for providing default values when there
is no container framework).
- Do not switch to a container framework in a rush; lets experiment how
they work without breaking FactoryRegistry for now, and remove or reduce
FactoryRegistry later if everything work well with the container.
- META-INF/services registration should continue to work even in a container
framework, because this is a standard and convenient way to register
services in a JSE environment.
Martin
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
