I'm in process of reviewing the recent changes in org.geotools.metadata.iso. I
noticed some problems:
Comparaisons
------------
There is some code like "if (a.foo == b.foo)" in various implementations. This
code do not work anymore. Remember to replace it by something like:
if (a.foo.intValue() == b.foo.intValue())
(Consider checking for null values first). Such change needs a search in the
code base; the compiler will not warn us.
equals(Object) implementation
-----------------------------
Codes like:
Double.doubleToLongBits(this.foo) == Double.doubleToLongBits(that.foo)
have been replaced by:
Double.doubleToLongBits(this.foo.doubleValue()) ==
Double.doubleToLongBits(that.foo.doubleValue())
This is not correct (no check for null value). A better replacement would be:
Utilities.equals(this.foo, that.foo)
I'm fixing some of those issues as I found them.
Martin
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
