Andrea Aime wrote: > Jody Garnett ha scritto: > >> Hi Rob >> >> Use a DataSource - that way you are not worried about if the connection >> is pooled or not. >> >> You will need to produce two factories for each datastore implemntation: >> #1: Take a DataSource in your DataStore constructor, the factory can >> make the connection (using whatever implementation you want like C3PO) >> #2: Take a JNDI name and use that to look up an already created >> DataSource , this what geoserver would use. >> > > What Geoserver may use, but in the usual case, I'm not going to ask > my users to setup connection pools in their application server. > I want the pools to be created with the usual parameters provided > withing a web app without knowing about the specific web container > details. > > Yet, if someones did configure a jndi pool, then we should be able > to use it. I would just like to keep more or less the current forms, > and have an extra parameter for a JNDI key, for users that prefer > to work like that. > I agree with this - but how to go about implementing it?
1) we dont want to duplicate this logic (choosing or using a JNDI source or creating a new one) - so it probably belongs in JDBCDataStore 2) again, we want to minimise dependencies on multiple implementations (surely?) - so what implementation of pooling are we using and do we want to use going forward? 3) it probably needs someone quite familiar with both JNDI and the state of the art pooling implementations to take this on (so I probably need to leave my own wrappers for ConnectionPoolDataSource in place) I see informed musings at http://geotools.codehaus.org/J2EE+and+Connection+Pools, but no JIRA task. Should this simply have a JIRA task created - or is it some form of serious change that needs a PMC decision first? I'm also not sure or the status of unsupported/oracle vs unsupported/oracle-spatial - if I was to update one to use org.opengis.filter, which should I attack? Rob A > Cheers > Andrea > > ------------------------------------------------------------------------- > This SF.net email is sponsored by DB2 Express > Download DB2 Express C - the FREE version of DB2 express and take > control of your XML. No limits. Just data. Click to get it now. > http://sourceforge.net/powerbar/db2/ > _______________________________________________ > Geotools-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
