Hi again,

Justin Deoliveira a écrit :

> Oh sorry, I did not see that you submitted the patch.

Well : I've managed to install Geotools source code with the help of 
Jody. It wasn't a piece of cake but, well.. Now I have to figure out how 
to update the project and how to deploy test cases ; this is still 
unclear to me :-)

> I looked it over 
> and it looks ok. The only danger i see with this patch is that more 
> exceptions are thrown then before,

Really ? If so, if wasn't my primary intention which was rather to wrap 
NPEs or even raise a SAXException before they occur.

> so existing client code may be in for 
> a surprise. However the new exceptions are good because they provide 
> better error reporting as opposed to just logging a warning.

That was my intention : it could probably be improved to output more 
meaningful messages about the offending structure and hence permit 
appropriate action. Consider my patch as a first step.

> I am +1 one on the patch. But I think we should also get jesse to review 
> it.

Sure !

Thanks you very much.

Regards,

p.b.


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to