Thanks for sorting out svn martin; I am sorry to have wasted your time (on something manual I could of corrected).
For a problem I could really use your input on ... DefaultFactoryTest is failing a test of assertSame. I am starting to suspect that we are tripping up on hints null vs GeoTools.getDefaultHints() ... thus two ReferencingFactoryContainers would be created resulting in the same definition being returned into the codestream twice. I wonder if someone somewhere is using "new" rather than ReferencingFactoryFinder. I also noticed that the code needed to "apply the defaults" to a set of user supplied hints is always the same - can we make a utility method on the GeoTools class for this? Jody PS. I am on IRC if you need explain things differently to me (with a pointed stick if needed) > Question number two here; and a code review request. > > The following two test cases: > - DefaultFactoryOnlineTest - in epsg/oracle > - DefaultFactoryTest - in epsg/hsql > > Have been giving me problems when they perform an: > - assertSame(((Conversion) operation).getMethod(), ((Conversion) > projection).getMethod()); > > I understand that this should serve as a sanity check that the > WeakHashSet is functioning correctly, and I am actually sure it is. I am > pretty sure that I am getting duplicate ReferencingFactoryContainer > instances created (each with its own ReferencingObjectFactory and thus > more than one instance created). > > I added the test case to ensure that these two are *equal* (and they > are), for now I have commented out the *assertSame* line and am asking > for help. > > Cheers, > Jody > Reminder: Please don't break the build during your morning Martin - I > have gone back and recovered the history. > > >> Looking at the META-INF/services folder for main I noticed the following: >> org.geotools.referencing.factory.epsg.DefaultFactory >> >> In my understanding DefaultFactory is an superclass for others to >> extend? Should it really be registered here (can it even do anything on >> its own?) >> >> Perhaps the intention was to list DefaultAuthorityFactory (so that >> others making use of the Factory SPI plugin system could find our work?) >> >> Thanks, >> Jody >> >> ------------------------------------------------------------------------- >> This SF.net email is sponsored by DB2 Express >> Download DB2 Express C - the FREE version of DB2 express and take >> control of your XML. No limits. Just data. Click to get it now. >> http://sourceforge.net/powerbar/db2/ >> _______________________________________________ >> Geotools-devel mailing list >> Geotools-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
