Hi Martin,
thanks for spotting the issues - almost all is clear to me and I'll correct it
ASAP.
I'm having just few additional comments and questions to these ones:
>WarpGridTransform2D.transform
>-----------------------------
>The method should declares "throws TransformException", and all "catch
>(TransformException e) {e.printStackTrace()}" block should be removed.
>
I'm aware of that but the declaration is missing in the super class
WarpTransform2D
as well (I was little bit lazy to invoke some trunk changes until I'll be sure
by my design).
Should we add it there?
>
>WarpGridTransform2D.worldToGrid
>-------------------------------
>Should we really carry this information? Current WarpGridTransform2D.transform
>implementation duplicates the work of ConcatenatedTransform in a less
>elaborated
>way. I would suggest to remove "worldToGrid" from WarpGridTransform2D and
>remove
>the transform method overriding as well. Instead, the factory could creates
>automatically a chain of WarpGridTransform2D and ConcatenatedTransform as
>needed.
>
I'm also aware of that. At first I did this as ConcatenateTransform but then
when trying to
make new DefaultOperationMethod(...) I'm getting:
org.opengis.parameter.InvalidParameterValueException: Argument "info" should
not be null.
at
org.geotools.referencing.AbstractIdentifiedObject.ensureNonNull(AbstractIdentifiedObject.java:1026)
at org.geotools.referencing.Properties.<init>(Properties.java:63)
at
org.geotools.referencing.AbstractIdentifiedObject.getProperties(AbstractIdentifiedObject.java:539)
at
org.geotools.referencing.AbstractIdentifiedObject.getProperties(AbstractIdentifiedObject.java:564)
at
org.geotools.referencing.operation.DefaultOperationMethod.getProperties(DefaultOperationMethod.java:121)
at
org.geotools.referencing.operation.DefaultOperationMethod.<init>(DefaultOperationMethod.java:106)
at org.geotools.coverage.grid.GridDemo.main(GridDemo.java:90)
Currently this is only reason why WarpGridTransform2D carried the worldToGrid.
This Exception
confuses me and I don't understand much what is the meaning of it.
Thanks,
Jan.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
