I just noticed the duplication is all.

I am also finding a few more things, 
org.geotools.feature.GeometryAttributeType does not implement the 
org.opengis interface of the same name and so on. Makes it tough when I 
am trying to use this api ... in particular:

type.find( type.getDefaultGeometry() );

Suppose this is why it is a release candidate ;-)
Jody


Justin Deoliveira wrote:
> A bit late to come up with a objection to the name as I beat these down
> peoples throats with multiple email threads before :). But I
> understand... you are only now getting a chance to do a formal review.
>
> So I am little confused. If your docs are constrained to SimpleFeature
> then why does the geotools.Feature interface matter to you?
>
> Jody Garnett wrote:
>   
>> Hi Justin;
>>
>> I am running into some inconsistences as I document up examples that are 
>> restricted to SimpleFeature and so forth...
>>
>> org.geotools.feature.Feature.getPrimaryGeometry(): Geometry
>> - a geometry that is somehow "preferred" and used as the default when 
>> rendering. In many cases this is simply the first geometry declaired.
>>
>> The same concept is represented in super classes ...
>>
>> org.opengis.feature.Feature.getDefaultGeometry(): GeometryAttribute()
>> org.opengis.feature.simple.SimpleFeature.getDefaultGeometryValue(): Object
>> - helper method for getDefaultGeometry().getValue()
>> - may be type narrowed by an implementation
>>
>> I would like to remove getPrimaryGeometry(): Geometry and replace it 
>> with getDefaultGeometryValue() type narrowed to Geometry for two reasons ...
>> - code completion will let people discouver the new method when they 
>> start typing getDefaultGeometry
>> - on less method for people to figure out
>>
>> What do you think?
>> Jody
>>
>> -------------------------------------------------------------------------
>> This SF.net email is sponsored by: Splunk Inc.
>> Still grepping through log files to find problems?  Stop.
>> Now Search log events and configuration files using AJAX and a browser.
>> Download your FREE copy of Splunk now >>  http://get.splunk.com/
>> _______________________________________________
>> Geotools-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>> !DSPAM:4007,46c91fb6104532090977483!
>>
>>     
>
>
>   


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to