Mmhh, this is probably something that got committed unintentionally
since it should be part of the uncommited work I am doing on
RasterSymbolizer.

Tomorrow, I'll look more closely to this, right now I do not have
access to that code.

Simone.

On 8/30/07, Martin Desruisseaux <[EMAIL PROTECTED]> wrote:
> Noticed a new addition in ColorUtilities:
>
>    public static BigInteger expand(final Color[] colors, final int[] ARGB,
>            final int lower, final int upper, BigInteger bits)
>    {
>        for (int i=lower; i<upper; i++) {
>            bits = bits.setBit(i);
>        }
>        ColorUtilities.expand(colors, ARGB, lower, upper);
>        return bits;
>    }
>
> Compared to the existing method, this new method adds a 'bits' additional
> arguments. But the javadoc said absolutly nothing about the purpose of this
> argument. Looking at the code, it seems to mix unrelated tasks. Why the loop 
> is
> not in a separated method, something like XMath.setAllBits(int lower, int 
> upper)
> method?
>
>
>        Martin
>


-- 
-------------------------------------------------------
Eng. Simone Giannecchini
President /CEO GeoSolutions S.A.S.
Via Carignoni 51
55041  Camaiore (LU)
Italy

phone: +39 0584983027
fax:      +39 0584983027
mob:    +39 333 8128928


http://www.geo-solutions.it

-------------------------------------------------------

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to