Justin Deoliveira ha scritto: > Hi Andrea, > > I am just now looking at the Feature part of your review. And here are > my comments. > > * Property exposing name and type from descriptor > > This is kind of tricky issue. I need to provide some context. Consider > for a moment two types of attributes: > > 1. An attribute that is part of another type > 2. An attribute that is at the top level > > In the first case Attribute.getDescriptor() != null, but in the second > case Attribute.getDescriptor() == null. The reason being that in the > second case the attribute is not part of another type... so there is > nothing to "descript". I know the javadocs do not state that at all... > they are horrible. > > Regardless, the name() method is as convenience which makes it so that > client code does not have to do a null check on the descriptor. For case > 2, name() returns null. > > However, getType() returns non-null in both cases. And in the first case > Attribute.getType() == Attribute.getDescriptor().getType(). > > Does that make any sense?
I guess so. But the real reason I would like the extra complexity level to be removed is another. I feel the answer to Martin's mail is a better place to answer this one, so "goto Martin's answer" :) Cheers Andrea ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
