Hi Andrea - can we get a few more details on the impact of the close method?
- ignore: I am more used to dipose() rather than close() after some eclipse experience ;-) - lifecycle: The close() needs to be stable regardless of how set up a datastore is (ie you can call it anywhere in the datastore lifecycle); you can call it more than once; it is threadsafe etc... (although the threads using the datastore may die die die) etc... - How dows close() interact with connection pools? Is it going to manage the internal connection pool (shut down the connections and kick out the lights?) Or if it is an external connection pool just ask postgis datastore to return any connections it was using? I have not yet been able to document your last quick proposal (introducing connection pools) :- ( Please make sure that some time is budgeted for documentation (after your release deadline if need be). I have made sure my name was not associated with your new proposal as far as documentation goes. And finally (with the assumption that the javadocs will make the above issues clear): +1 Jody Andrea Aime wrote: > Hi people, > sorry to try to hurry you up, it's just that I'd like to have this > one in in time for GeoServer 1.6.0 beta4 (which will be released > early next week). > > Cheers > Andrea > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a browser. > Download your FREE copy of Splunk now >> http://get.splunk.com/ > _______________________________________________ > Geotools-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
