Martin Desruisseaux ha scritto: > I noticed the introduction of following fields in org.geotools.factory.Hints: > > public static final String VALUE_OVERVIEW_POLICY_QUALITY = "Quality"; > public static final String VALUE_OVERVIEW_POLICY_NEAREST = "Nearest"; > public static final String VALUE_OVERVIEW_POLICY_SPEED = "Speed"; > > used by > > public static final OptionKey OVERVIEW_POLICY; > > Since we are on Java 5, can we replace the three above values by an > "OverviewPolicy" enum? Hints will also be easier to read if all constants in > this class are Keys, and all values are defined outside (as enum or whatever).
I have nothing against that. Yet, I'd like to backport these changes on 2.4.x after the 2.4.0 release. Would this "way" of declaring the enum be ok? I copied another OptionKey that I believe is used by the referencing modules, but I wasn't comfortable with keeping the strings just strings (that other option repeats the same strings in every usage point). Cheers Andrea ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
