Hi Andrea, Glad you tracked it down. I looked over the patch and have a slight alternative. Instead of tracking wether there is a connection problem in the MySQLTestSetup, I think it wold also work if we did it right in JDBCTestSupport#setup(). This way the check is in a single place and we dont have to worry about doing the same trick for other databases when they get implemented. How about I commit the patch and you try it out.
I also notice from your patch that some test methods are commented out stating that they break the build. Any idea what is going on there? -Justin Andrea Aime wrote: > Hi, > looking at why the h2 module takes so long to build, > I discovered that in fact it's due to a timeout. > The mysql datastore tests are trying to connect to > a mysql db is not on my pc, but they take each 2 seconds > to give up (why, I don't know... probably there is something > on the usual mysql port that's responding so it takes a > failed handshake to give up...) > > You multiply that for each test and you get why its > taking this long to build on my pc. > > We either can turn these into full online tests, or > alternatively I have a patch that can fix the issue > attached to this mail: basically I changed a little > the contract of JDBCTestSetup.createDataSource(), allowing > it to return null if no connection could be made, > and made MySqlTestSetup keep a static cache of the > connection attempts (so only one connection attempt is performed). > > Cheers > Andrea > > > !DSPAM:4007,47761a68125371096210785! > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2005. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > > !DSPAM:4007,47761a68125371096210785! > > > ------------------------------------------------------------------------ > > _______________________________________________ > Geotools-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > > !DSPAM:4007,47761a68125371096210785! -- Justin Deoliveira The Open Planning Project http://topp.openplans.org ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
