Hello Simone
I'm looking at ImageWorker right now because I may need it for a PNG image
processing. I noticed a couple of things:
* There is a "loadPlanarImageImage" method. I guess it is a typo and the
name should be "loadPlanarImage"? If so and with your permission, I
could apply the renaming since I'm at it.
* There is a "gifSPI = new GIFImageWriterSpi()" private constants. This
value should probably be fetched from javax.imageio.spi.IIORegistry
instead of depending directly to com.sun internal classes. On a related
note I wonder, unless I'm missing a reason, could we replace:
final ImageWriter gifWriter = new GIFImageWriter(gifSPI);
by
final ImageWriter gifWriter = gifSPI.createWriterInstance();
? if you agree, I would apply those changes which would avoid direct
dependency to those com.sun classes, and also class loading of GIF
readers for those who don't need it.
* There is a new ImageWorker() argument which create an unitialized worker.
Javadoc said it is for image read, but the only "read" or "load" method
I found is static. Can we either remove the no-arg constructor and turn
the load image into a member method? I would prefer the second approach
because it would integrate well with ImageWorker - we can remove the
RenderingHints argument and use the one specified by ImageWorker methods
instead, etc.
Martin
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
