On Jan 10, 2008 9:52 PM, Martin Desruisseaux <[EMAIL PROTECTED]> wrote: > Hello Simone > > I'm looking at ImageWorker right now because I may need it for a PNG image > processing. I noticed a couple of things: > > * There is a "loadPlanarImageImage" method. I guess it is a typo and the > name should be "loadPlanarImage"? If so and with your permission, I > could apply the renaming since I'm at it.
Sure thing, go ahead. > * There is a "gifSPI = new GIFImageWriterSpi()" private constants. This > value should probably be fetched from javax.imageio.spi.IIORegistry > instead of depending directly to com.sun internal classes. On a related > note I wonder, unless I'm missing a reason, could we replace: > > final ImageWriter gifWriter = new GIFImageWriter(gifSPI); > by > final ImageWriter gifWriter = gifSPI.createWriterInstance(); > > ? if you agree, I would apply those changes which would avoid direct > dependency to those com.sun classes, and also class loading of GIF > readers for those who don't need it. no problem on this. > > * There is a new ImageWorker() argument which create an unitialized worker. > Javadoc said it is for image read, but the only "read" or "load" method > I found is static. Can we either remove the no-arg constructor and turn > the load image into a member method? I would prefer the second approach > because it would integrate well with ImageWorker - we can remove the > RenderingHints argument and use the one specified by ImageWorker methods > instead, etc. > > Martin > > No problem on that. I guess the LoadPlanarImage method was there as a shortcut whend doing tests and the like, hence I think we can convert it to what you suggest without too much grief. Ciao, Simone. -- ------------------------------------------------------- Eng. Simone Giannecchini President /CEO GeoSolutions S.A.S. Via Carignoni 51 55041 Camaiore (LU) Italy phone: +39 0584983027 fax: +39 0584983027 mob: +39 333 8128928 http://www.geo-solutions.it ------------------------------------------------------- ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
