Hey all,
Working my way through the new feature model, there is a lot of overlap
between the old effort and the new. It's unclear how much of this is
work-in-progress, how much is not-yet-deprecated cruft, and how much is
purely my confusion.
I hope we could clean some of this up and add explanations to the
documentation to help the next person trying to sort out featureNew.
Notation used below:
oog is org.opengis
ogt is org.geotools
FeatureCollection and events:
----------------------------
oog.feature has:
FeatureCollection
DataFeatureCollection
FeatureEvent
FeatureListener
ogt.feature (in gt-api) has:
FeatureCollection
CollectionEvent
CollectionListener
Is oog.feature.FeatureCollection currently unused, with
ogt.feature.FeatureCollection used instead? Is this work-in-progress? Is
the geotools version really a SimplefeatureCollection but not renamed to
avoid impacting user code?
Is oog.feature.DataFeatureCollection an old idea since it is not used
anywhere in geotools? If we want to keep it, could its name be changed
to something more descriptive liked ExternalFC or BackedFC or
PeripheralFC? Why are the listener methods here and not in directly in
the parent FeatureCollection (also,see next)?
There are several very similar event and listener classes:
oog.feature.FeatureEvent and oog.feature.FeatureListener
ogt.feature.CollectionEvent and ogt.feature.CollectionListener
ogt.data.FeatureEvent and ogt.data.FeatureListener
Could we rename the GeoAPI interfaces are to be kept, can we rename them
to FeatureCollection[Event/Listener] to clarify what they are for (also,
see previous)? Can we simplify the overlap between these classes in any
way? Could we add some javadoc explaining the difference between these?
Gt API Name, NameImpl:
---------------------
These are essentially identical with the latter having been edited more
recently. Can we change the former to extend the latter and deprecate it
or simply remove it?
Gt API filter:
-------------
Most of the classes in ogt.filter in the gt-api module seem to be
deprecated but this appears to not have been done systematically so, for
example, Expression is deprecated but not ExpressionType which it
extends. So what's going on?
enough for now since as I dig, I'm getting more confused.
--adrian
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
