Thanks Justin, All good feedback and I will be sure to include the changes.
Graham. Justin Deoliveira wrote: > Hi Graham, > > Took a quick look over it, looks pretty good, nice and simple :). Just > a couple of minor things: > > * ProcessFactory#getParametersInfo(): > > The plural sounds kind of wierd... i think getParameterInfo() sounds > better. ( minor i know :) ) > > * ProcessFactory#isValid(Map): > > I assume that this is a pre-check that is done to make sure the > factory can handle the given parameters? In most places i have seen > this type of method called "canHandle", you may want to change it. > Another thing to consider might be to just get rid of it all together, > and have the contract state that if the factory cannot handle the > parameters it should just return null from create(). One less method > is always better. If i am misunderstanding the point of the method i > apologize. > > * Parameter#metadata: > > What about changing the type from Object to a Map. There may be > multiple types of "context", or "metadata" to provide to the process. > It would also serve as a way to provide hints to the process. > > Thats about it from me. I am sure you will get much more feedback from > others :). > > -Justin > > > Graham Davis wrote: >> As discussed in today's geotools meeting, I will be working on 2 new >> modules: a Process API module and a WPS module. >> >> The Process API module (wiki page here: >> http://docs.codehaus.org/display/GEOTOOLS/Process+API) will be a >> "simple" interface for creating processes/operations. This is based >> on a proposal written here: >> http://docs.codehaus.org/display/GEOTOOLS/Process+proposal >> >> The WPS module (http://docs.codehaus.org/display/GEOTOOLS/WPS+Module) >> will use that interface to begin creating a WPS framwork that can be >> used from GeoServer, etc. >> >> I am hoping to create these 2 new modules in the unsupported section >> of the SVN. I already have contributor access as I've worked on the >> geometry module before. Can I get approval to begin creating these >> modules? >> > > -- Graham Davis Refractions Research Inc. [EMAIL PROTECTED] ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
