Hi, so I've been working on adding support to SqlBuilder for encoding plain filters and plain expressions. This made me have a look around in the filter encoding stuff... here is some feedback: * SQLEncoderException is deprecated but everything is throwing it anyways, with a reminder to throw FilteToSqlException instead once SQLEncoder is gone. Hmm... why a "deprecate, subclass and replace" approach hasn't been used instead? Changing the exception thrown is going to break the API once more... * there is something strange going on in the filter encoders... they do check if the filter is fully supported before proceeding, but that in turn does not check whether the expressions inside the filter are supported, leading to a situation where one could break encoding by passing a supported filter that uses an unsupported function. I've opened a jira for this: http://jira.codehaus.org/browse/GEOT-1801 * lucky as I am the unit tests I added to check expression encoding uncovered other bugs in FilterToSql: http://jira.codehaus.org/browse/GEOT-1802
Cheers Andrea ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Don't miss this year's exciting event. There's still time to save $100. Use priority code J8TL2D2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel