Jody Garnett ha scritto: > I understand the motivation; and I don't want to inflict logic > expectations on factory writers if we can find another way. Can we make > a FilterFactoryWrapper that performs validation. The code can find > problems like this; and depending on a "strict" flag produce either a > warning (and fix the problem) or throw an exception...
Validation? Warnings? Sorry? A filter like "INCLUDE and INCLUDE and EXCLUDE" is perfectly valid, it's just redundant. I was speaking about simplification, not validation. Moreover, a wrapper cannot change the fact ff.and(...) must return and And filter, whilst a smart builder would have to return Filter, generically. I don't know about fallbacks and stuff, but remember, we have a very extensive code base and adding the builder everywhere is going to have quite a cost (the old filter migration, still unfinished, should have teached us something...) Cheers Andrea ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
