Jody Garnett ha scritto: > Andrea Aime wrote: >> Two proposals: >> * move StyleAttributeExtractor to rendering, there is >> actually nothing in gt2 using it besides rendering >> > Agreed - move it.
Cool >> * subclass both of those classes in renderer to take >> care of the dynamic symbols proposal >> > Eventually I would like to move the style implementation into renderer > as well; nothing else in main makes use of it. I believe the go renderer might use them? Instead of moving to renderer, what about a gt-style module? Anyways, I'm not going to make that change right now, I'm just talking. >> I like the first one better, but I'm open to the second one as well? >> Opinions? If no one says anything I'll >> perform the move soon (say, in two days, to allow for someone to reply?). >> > > Quick question does the class need to be public? And can we document it > here: > - > http://docs.codehaus.org/display/GEOTDOC/08+StyleVisitor+use+with+DuplicatingStyleVisitor+and+RescaleStyleVisitor > Does the class need to be public? Yes, we use it in the shapefile renderer as well, the GO renderer might be interested in using it too (along with SLDStyleFactory and company, which would make it dependent on the renderer module). About documenting it, I believe that just pointing to the class is sufficient, people can look the javadoc. I don't see the need of a tutorial like docs for a class that's used only for optimization purposes in the renderers? Cheers Andrea ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
