Hi Jody, my understanding from yesterday's meeting was that we needed to branch 2.5.x in order to not hold back other projects, but no release were needed so 2.5.x becoming a development branch means we can tackle those pending issues after the branch is created. Is this possible at all?
more comments inline On Tuesday 22 July 2008 04:25:00 pm Jody Garnett wrote: > Thanks David: > > One question before we start: > - Gabriel? Andrea and myself were talking about keeping FeatureIds > stable during a geoserver transaction; the quick solution involves > feature events (you are aware of the work) the nice solution involves an > API change. Can you review the email messages on this topic and advise > please. what bothers me is the three way communication path to get at the generated feature ids: - if in auto commit, catch an event per feature to get the id - if in transaction, catch the event for the whole transaction with the set of ids - either way, addFeatures() returns the set of ids Yet the need for it is recognized to be the inability to generally get to the actual id before commit. So imho of the options you worte about the one I feel better with is: Option Two (for GeoServer) ======== Either change api to reflect the need to produce a list of good feature ids in order with no events - change addFeatures to return a List<FeatureId> - record these FeatureIds in a big list from all DataStores - the values will be correct after commit() is called; (all the event stuff uDig uses will be needed for the values to be correct; but geoserver does not have to listen to them at runtime) but still the FeatureId changing under your feet (it is an immutable interface) leaves me a bit uncomfortable. Would it be too crazy for a FeatureEvent of type COMMIT to hold a Map<FeatureId, FeatureId> mapping the pre-commit (and hence volatile) ids to the persisted ones so there's no magic going on? FeatureEvent.getNewIds():Map<FeatureId, FeautreId> Gabriel. > > We have a couple of things to do before the branch: > - Call a code freeze (depending on Gabriel's answer above) > - http://jira.codehaus.org/browse/GEOT-1896 User Guide must include all > licenses > - http://jira.codehaus.org/browse/GEOT-1907 Need to review LICENSE files > - http://jira.codehaus.org/browse/GEOT-1873 OWS module headers - > jdeolive is module maintainer > - http://jira.codehaus.org/browse/GEOT-1877 XSD module headers - > jdeolive is module maintainer > > And one thing to do after the branch: > - Martin has been unable to complete a review of > (http://docs.codehaus.org/display/GEOTOOLS/Improve+CRSAuthority+Concurrency >+Caching+and+Connection+Use) and would like us to back the change out of the > 2.5.x branch after it is created. > > David we are going to have to wrangle up people to do this work; > tomorrow morning is not enough notice :-) > > Cheers, > Jody > > > Hi all, > > > > I think understand the creation of the 2.5.x branch for geotools has > > been waiting on the go-ahead from GeoServer. We're definitely ready to > > create this branch now. We'd like to follow the following plan to > > create a release ASAP: > > > > * branch 2.5.x immediately > > * build geoserver against it, run CITE tests > > * once CITE tests are passing, create a release to use for geoserver > > 1.7.0rc1. > > > > We'd like to create the branch tomorrow morning, so please take care of > > any outstanding commits before then or raise an issue on the mailing > > list if that's a problem. > > > > -David Winslow > > > > > > ------------------------------------------------------------------------- > > This SF.Net email is sponsored by the Moblin Your Move Developer's > > challenge Build the coolest Linux based applications with Moblin SDK & > > win great prizes Grand prize is a trip for two to an Open Source event > > anywhere in the world > > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > > _______________________________________________ > > Geotools-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge Build the coolest Linux based applications with Moblin SDK & win > great prizes Grand prize is a trip for two to an Open Source event anywhere > in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Geotools-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > > !DSPAM:4045,4886341171711637810514! ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
