Tara Athan a écrit :
> I have been looking into GEOT-411, listed under the "Trivial" bugs category.
Considering the issue you pointed (making sure that points in arrays do not
overwrite each other when the source and target dimensions are not equal), the
"trivial" category is probably innacurate for this issue.
> I have sketched out some modifications to MolodenskiTransform.java that
> would take care of the issues involving overwriting the array of source
> points when the dimensions are not equal (2 or 3 dimensions are allowed
> for either source or target). Basically the issue is that, depending on
> the starting indices, it can be a little tricky to avoid overwriting a
> point that hasn't been transformed yet (when the target array is the
> same as the source array).
The ConcatenatedTransform classes faced a similar issue. I do not remind
exactly
how we handle them, but if my memory is not too bad we put a helper methods for
that in AbstractMathTransform.
> I would like to test this out to make sure it will really work OK.
> However I don't see any existing test code for this class - is this
> correct, or am I missing something? This is especially significant
> because I think I have found an error in the original code that could
> cause an infinite loop, and I would like to verify and correct that
> before moving on to modifications.
It may be that there is not test case for exactly that class. However it is
tested indirectly when testing the transformations between CRS using different
datum. However a direct test specifically for MolodenskiTransform would be
better. If there is no MolodekskiTransformTest class in referencing/src/test
directory, then we don't have such a test right now...
Regards,
Martin
P.S. Just a side note: more generally speaking, I'm looking for a way to move
as
much referencing test as I can from GeoTools to GeoAPI. It would allow other
projects to share partially their test suite. I will keep peoples on mailing
list informed.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
