Martin- are you also addressing the case where the source and target dimensions are different? That was the next issue with the Molodenski that I was going to look at. Tara
Martin Desruisseaux (JIRA) wrote: > [ > http://jira.codehaus.org/browse/GEOT-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Martin Desruisseaux resolved GEOT-2046. > --------------------------------------- > > Resolution: Fixed > > Commited on trunk (GeoTools 2.6) and on 2.5 branch as of revision 31569. > Thanks a lot for submitting the patch. > > By coincidence, this JIRA task has been submitted at a moment where a was > working on this issue for all MathTransform (rather than a fix for > specifically Molodenski). I'm trying to put in a single place the code > selecting an iteration strategy (ascending order, descending order, copy in > temporary buffer...) according the source and target offset. > > > >> MolodenskiTransform fails in some cases when the output array overwrites the >> input array but with an offset >> ----------------------------------------------------------------------------------------------------------- >> >> Key: GEOT-2046 >> URL: http://jira.codehaus.org/browse/GEOT-2046 >> Project: GeoTools >> Issue Type: Bug >> Components: core referencing >> Affects Versions: 2.5-RC0, 2.6-M0 >> Environment: all environments >> Reporter: Tara Athan >> Assignee: Martin Desruisseaux >> Priority: Minor >> Fix For: 2.5.0, 2.6-M0 >> >> Attachments: MolodenskiTransform.java, MolodenskiTransformTest.java >> >> >> When overwriting an array with the transformed coordinates, sometimes it is >> necessary to work in reverse, from higher indices down, in order to avoid >> overwriting points that have not yet been transformed. This happens when the >> source and target dimensions are the same and the target offset is greater >> than the source offset. (Note: the situation when the source and target >> dimensions are different is more complicated, and is not implemented in >> MolodenskiTransform at this time.) >> The code for carrying out this reverse iteration through the arrays >> contained a bug which caused it to write all the transformed coordinates >> into a single location, causing all but the last transformed coordinates to >> be lost. The patch fixes this error. >> > > > ------------------------------------------------------------------------ > > > No virus found in this incoming message. > Checked by AVG - http://www.avg.com > Version: 8.0.169 / Virus Database: 270.7.0/1683 - Release Date: 9/21/2008 > 10:10 AM > > -- My e-mail delivery has been unreliable lately, so I am asking for return receipts from all my email messages. OK'ing the return receipt lets me know that my message was delivered. Thank you. Tara Athan Principal, Alternatives to Invasive Species tara_athan [AT] alt2is.com 707-485-1198 PO Box 415 Redwood Valley, CA 95470 ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
