Pretty cool stuff andrea. I don't have much to add beyond what you and jody have discussed. Looking forward to checking it out.
Jesse On 22-Dec-08, at 11:15 AM, Andrea Aime wrote: > Hi, > so I'm looking into the details of contributing the > improved labeller I've developed for GeoServer > back to GeoTools. > > The new one is split into five classes (compared > to the two of the current one) so it would be better > to allocate a package for it. > > What about org.geotools.renderer.labeller? > Or org.geotools.renderer.lite.labeller? > > I'm also wondering about the class named. Atm > the classes are named: > - GSLabelCache (the main class, groups the labels, > locates the label position with the help of the rest) > - GSLabelItem (holds the informations about a single > label) > - LabelIndex (spatial index of the labels drawn so far) > - LineStringCursor (helps walking along a linestring) > - GSLabelPainter (actually draws the label, either > straight or curved) > > Of course GS* is not a good naming. Any sort of > New* Advanced* *NG is going to become incorrect > in a matter of months (when something else might > become "new"). > > So what about just calling it again LabelCacheDefault? > Or better, DefaultLabelCache? The different package > will avoid naming clashes. > For the other GS* classes I'd suggest to just remove > the prefix. > > How does this sound? Let me know. > > Cheers > Andrea > > -- > Andrea Aime > OpenGeo - http://opengeo.org > Expert service straight from the developers. ------------------------------------------------------------------------------ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
