Justin Deoliveira ha scritto: > Just to clarify a bit my position. If we were coming up with a new api I > would be for having false (non-reliable) fids as the default. But it is > my understanding that most client code operates under the assumption > that datastores report reliable fids, and those that don't are sort of > "broken". So flipping that assumption seems a serious break to backward > compatibility. > > Also as written we will need to update all datastores to return true. > when they return a repeatable fid, which is the majority of them afaik. > The patch only deals with shapefile and the old postgis. Returning true > by default would mean we only need to update the cases where this is not > so, as far as i know this amounts to database tables with no key set.
I agree the implementation should return true by default. Inconsistent fid datastore came long after we designed the datastore api, basically the day we started working on views on jdbc datastores. The only other datastore whose fids _may_ be made up is a WFS datastore, but in this case there is no real way to tell. The fids returned are expected to be consistent by CITE so I'd say we should default on consistent fids for that one too, leaving only JDBC datastores with the issue of having inconsistent fids. Shapefile is kind of a strange beast. Fids are consistent as long as no record is deleted, after that... hum... it depends. As far as I remember they are consistent even after deletes provided the .fix file is not touched by external applications? Jesse? Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ Check out the new SourceForge.net Marketplace. It is the best place to buy or sell services for just about anything Open Source. http://p.sf.net/sfu/Xq1LFB _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
