Jody Garnett ha scritto: > Andrea can I ask if this is a problem with the SLD parser; or a problem > with the data structures?
The data structures. Fixing the parser is a piece of cake. > I tried to carefully make the geometry > operations reduce their values to two expressions; the String based > PropertyName accessors are still there; but have warnings that they only > work with the expression used is a PropertyName. > > This was one of the motivations for FilterFactory2 > (http://geoapi.sourceforge.net/snapshot/javadoc/index.html). So you must > be talking SLD / SE. Sorry? That did not get into the symbolizer implementation, not even on trunk, as far as I can see. When I wrote the mail my IDE was open on 2.5.x, and I did not think about the SE effort, but looking at the interfaces now, there are still just plain strings, even in GeoApi: org.opengis.style.Symbolizer (geoapi): String getGeometryPropertyName(); Happily enough we're not stuck with GeoApi interfaces, as GeoTools still has its own ones, and they are not deprecated, so it's still possible to pull such a change without having to go through a committee. Thought I must say this is going to be confusing for the user as code completion will always report two PointSymbolizer, just like now we have two Filter and two Expression and so on. > I would like to see if we can make that a choice; based on your examples > I can only see the use of Function or PropertyName right now (are their > any other useful possibilities?). I don't understand what is the advantage of limiting the scope. You have an expression, you do this: Geometry g = geomExpression.evaluate(feature, Geometry.class); and that's it, how it's being built up internally should not matter, no? Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
