On Tue, Mar 3, 2009 at 2:58 AM, johann sorel <[email protected]>wrote:
> Hi again,
>
> I've just maid my first complete review of the styleFactory.
>
> the major things I have fixed :
> - missing rotation parameter on several creation methods
Good catch.
>
> - symbolizer creation methods wanted an Expression, but the Symbolizer
> interface has only
> a method to return a String value. The specification define the geom as a
> String, so I changed the
> factory methods.
I will change it back then; and make the suggestion to improve symbolizer.
Same rational as with the PropertyName handling for geometry expressions.
>
> - stroke creation method was allowing GraphicStroke, GraphicFill and Color
> at the same time. (hoping only one will be set) I separate those in 3
> different methods to avoid possible mistakes.
Nicely done.
Jody
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
