Hi Jody, Thanks for catching the Envelope usage - much better.
Yep - I was unsure about class names. On the one hand they are inconveniently long. On the other that means they get grouped together in the javadocs when you're using the 'All classes' listing (as I generally do). I don't feel strongly either way so happy to go with whatever you and others think is best for users. I'd appreciate any suggestions on rationalizing the current stream of consciousness scheme with mouse listener / tool interfaces and the JMapPaneToolManager class. The idea was that only some tools would be cursor tools, while others would just want to listen to mouse events (such as a status bar class to display map coords, xor-box bounds etc). It's just a bit of a mess at the moment. cheers Michael 2009/3/3 Jody Garnett <[email protected]>: > Thanks Michael; the Hudson build is still down until it does a fresh > checkout (since it cannot checkout over top of its old demo/mappane-uses > folder). I hope someone does not need to go into that server and fix it? Is > there an svn update flag that will remove folders? > I did a couple quick reviews as I updated old code: > - Explicit handling of Envelope2D was not needed; relaxed to geoapi Envelope > (so ReferencedEnvelope will work out of the box as is). This would of been > caught during the general roll out of ReferencedEnvelope if mappane was a > supported module - if you find any other cases like this please go ahead and > fix > - Change to CursorTool (or whatever the class was) results in very long > names; I may want to go back and rename this to be simply "Tool" in order to > be more approachable to people. > Are there any areas that you would like me to check over? > Jody > > > On Tue, Mar 3, 2009 at 2:20 PM, Michael Bedward <[email protected]> > wrote: >> >> ok - I resurrected the mappane-use demo. Ian's MapViewer class just >> needed a few import / class name changes and it now builds ok. The >> intro demo builds now too. >> >> Meanwhile labelling of features (e.g. with countries.shp in the >> mappane-use/data dir) will not work properly right now. I've stripped >> out the label-related code (along with selection and highlighting >> code) from JMapPane and propose to add each of these to the new code >> when there is some feedback about its organization (which is >> stream-of-consciousness at the moment). >> >> Michael > > ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
