Martin Desruisseaux wrote: > Hello Andrea > > I had a quick look at the patch you posted at > http://jira.codehaus.org/browse/GEOT-2363 and I'm fine with it. If you > have that change ready to commit on your local SVN, would you like to > commit them? Alternatively I can commit your patch if you prefer - at > your choice, just let me known.
I can commit it. I was tghinking of rolling a separate method setCode(preparedStatement, int index, String code) so that subclasses can override the defult behavior and use setString instead. That should handle the IGN specific case. > For http://jira.codehaus.org/browse/GEOT-1770 I'm fine with you applying > the patch. But I think that no matter what we do, we will probably need > to put a smaller timeout anyway - 1 hour is probably too long. Hum, I don't know. Connection pools by default assume the connection will live forever, and allow for adding a validation query for connection verification prior to actual usage. With the patch the timeout is actually not needed anymore? Cheers Andrea ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
