Just a couple comments before I start work for the day ...
> Ok, NOW I really understand what you're talking about! Fine then, I'll
> copy SLDParser for v1.0 and call it SEParser for now (which in fact will
> become a SLD+SEParser for v1.1). Later on, if we want, we can extract a
> real SLDParser v1.1 from that code.
:-) Sounds like a plan.
>
> I have a new StyleFactoryInterface defined in geoapi; I think it
>> already has the UOM parameter.
>>
>
> Wow, that makes things even easier. I almost feel like I won't be doing
> much in the end.. :) Hmm, but it took me a little time to find it: it's
> in geoapi 2.2, not 2.3 right?
>
> http://geoapi.sourceforge.net/snapshot/javadoc/org/opengis/style/StyleFactory.html?is-external=true
> (I guess 2.3 was split, I don't know if there are javadocs around for
> the rest of it)
I am doing this work on 2.6.x which as of a few days ago uses GeoAPI
2.3-SNAPSHOT.
>
> I am still torn on the use of setXXX
>> methods; I understand why it is done (so we can renderer faster); but
>> I am considering a hybrid approach where you can call set methods ]
>> until a method "freeze" is called at which point the set methods would
>> call an illegalstate exception.
>>
>
> Don't know, for me that does look a lot like a builder, where you call a
> lot of setXXX and then get the thing ready by calling build(). I guess I
> would prefer that than having exceptions thrown now and then.
Yeah you are correct - stateful data structures is a bad idea. The
alternative is to synchronize everything up and make the data structure
thread safe. That would not be too bad since this code is used to make
decisions and should not be called in time critical threads; but I would
like to check with Andrea first to see if he would kick me for harming
performance.
The GeoAPI StyleFactory is shaping up to be a joy to use. I have not yet
thought about making a builder (to help people create this data structure in
an easy fashion). For our purposes this will be fine; we can call the
factory methods directly - and they will do exactly what we want with no
funny defaults being thrown in.
>
> Can you be more specific? if the binding framework is not working I
>> would like to know - as far as I know it is handling its test cases in
>> a reasonable fashion?
>>
>
> Well, I ran only a simple test to see how a .sld file I have here for a
> countries polygon shapefile would render.
Looks like Andrea is already talking to you about this; I would like to try
and debug the problem (or at the very least can we make a bug report and
attach an sld file that illustrates the problem?).
Jody
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
