Hi,

I just found out, that the getBounds Method in MemoryDataStore does not work 
correctly. The org.geotools.gui.swing.map.map2d.stream.TempMemoryDataStore is 
also affected. The reason is the creation of a ReferencedEnvelope without a 
check whether the filter matches the first Feature.

I guess it is a bug! Should I create an issue in jira for it and for which 
module?

 I append a patch for that. Maybe it's easier to understand what I'm talking 
about ;)

Thanks and have a nice weekend!

Frank


Nice catch; patch applied to trunk - if the tests pass I will commit. 
> Appollogizes for the short email I am supposed to be doing other 
> stuff today (but encouraging patches is always a good thing).
> 
> Only feedback I had was to return an "empty" ReferencedEnvelope with 
> the right sourceCrs when all other options fail. I also checked with 
> the CRS.getEnvelope(sourceCRS) comes back null - according to its 
> javadocs it is allowed to return null for the crs definitions that do 
> not specify a domain of validity.
> 
> I kind of would like to change that method to return an empty 
> envelope with the correct crs; rather than return null in order to 
> match our developers guide.
> 
> What do you think Martin?
> 
> Jody

Attachment: MemoryDataStore.patch
Description: Binary data

------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to