Christian Müller ha scritto:
> 
> Hi Andrea
> Taking a quick look at the streamingrender leads to 2 questions
> 1)
> If the feature source supports both hints (which is ok), you pass both 
> of them to the feature source.
> What are you exepecting, best fit geometries or already simplified 
> geometries. When quering features you can use only one of our 3 hints.
> I think the code sequence
>  if(fsHints.contains(Hints.GEOMETRY_DISTANCE))
>      hints.put(Hints.GEOMETRY_DISTANCE, distance);
>  if(fsHints.contains(Hints.GEOMETRY_SIMPLIFICATION))
>      hints.put(Hints.GEOMETRY_SIMPLIFICATION, distance);
> should be
>  if(fsHints.contains(Hints.GEOMETRY_SIMPLIFICATION))
>      hints.put(Hints.GEOMETRY_SIMPLIFICATION, distance);
>  else if(fsHints.contains(Hints.GEOMETRY_DISTANCE))
>      hints.put(Hints.GEOMETRY_DISTANCE, distance);

Indeed you're right.

> 2) If the feature source supports Hints.GEOMETRY_SIMPLIFICATION it seems 
> that  you do your own decimation again, but the the geometries are 
> already simplified. I did not see a line of code where you are 
> preventing decimation in this case.

I warned you I would be doing this to avoid bigger changes in the stable 
series (read my mails in this thread again, I'm pretty sure I wrote this
in one of them). I would also be very surprised if you could find
the needless generalization taking any significant time in WMS
requests (not to mention WFS requests where the time is usually
dominated by writing GML itself).

Cheers
Andrea

-- 
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.

------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to