Yeah, this is something i have gone back and forth on, removing this 
logging statement. I have found it to be useful however when debugging.

So Ben already added the guard to avoid the actual conversion, we 
probably just need to add the same guard for logging a missed conversion?

Alternatives would be to:

a) log it as the maximum possible debug level
b) do the log the parent object directly, but just the class of the parent

-Justin

Gabriel Roldan wrote:
> Hi,
> 
> Working with an app-schema configuration on trunk works but the log gets 
> full of messages comming from GetPropertyExectutor, line 83:
> 
> LOGGER.fine("Could not convert " + parent + " to "
>                         + binding.getType().getName());
> 
> the messages look like the one bellow and are logged once per 
> ComplexAttribute. I'm not quite sure what the correct action to take is, 
> if relaxing the check and verify ComplexAttribute is a valid type for 
> the binding. At least I think we should avoid printing the full 
> attribute contents and instead just the attribute name?
> 
> Example message:
> 20 May 18:58:18 DEBUG [org.geotools.xml] - Could not convert 
> ComplexAttributeImpl:service<ServicePropertyType>=[FeatureImpl:Service<ServiceType
>  
> id=service_4_4_4>=[ComplexAttributeImpl:name<CodeType>=[ServiceGroup_4_4], 
> AttributeImpl:name<string>=service 31, AttributeImpl:status<string>=0, 
> AttributeImpl:summary<string>=ex:summary, 
> AttributeImpl:headline<string>=ex:headline]] to org.opengis.feature.Feature


-- 
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, & 
iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://www.creativitycat.com 
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to