Log a warning when an unsupported geometry type is skipped
----------------------------------------------------------

                 Key: GEOT-2524
                 URL: http://jira.codehaus.org/browse/GEOT-2524
             Project: GeoTools
          Issue Type: Improvement
          Components: data jdbc, data jdbc-ng, data oraclespatial, data postgis
    Affects Versions: 2.5.5
            Reporter: Ben Caradoc-Davies
            Priority: Minor


Unsupported geometries are silently skipped. Known to affect gt-oracle-spatial. 
Should probably check that all other data stores log a warning so that users 
can diagnose this problem. One issue is that, if there are many skipped 
geometries and users rely on this behaviour, large amounts of unwanted log 
information may be written. Perhaps only log the first time an unsupported 
geometry is seen? Watch the nasty state creep into the data store ...

Original bug report (addresses expunged):

{code}
-------- Original Message --------
Subject: [Geoserver-users] where can I find gt-oracle-spatial-2.5.5.jar source 
code?
Date: Fri, 29 May 2009 04:44:00 +0800
From: Sarah Haskins <...>
To: geoserver-users ...

Hi all-

I'm having an issue when using the oracle spatial plugin.  There are 2
rows in my table that when selected from the WFS fail to return any
point/shape information.  This happens on even a simple WFS getFeature
filtered by ID, like below.  One OBJECTID value is working and
returning all 6 columns from my table, while the same request for
another OBJECTID is returning only 5 columns, always excluding the
SHAPE/spatial column.

<wfs:GetFeature service="WFS" version="1.1.0"
xmlns:myns="http://my.url"; xmlns:wfs="http://www.opengis.net/wfs";
xmlns:ogc="http://www.opengis.net/ogc";
  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://www.opengis.net/wfs
http://schemas.opengis.net/wfs/1.1.0/wfs.xsd";>
  <wfs:Query typeName="myns:FEATURE_NAME">
 <ogc:Filter>
<ogc:PropertyIsEqualTo>
<ogc:PropertyName>OBJECTID</ogc:PropertyName>
<ogc:Literal>716</ogc:Literal>
</ogc:PropertyIsEqualTo>
</ogc:Filter>
    </wfs:Query>
</wfs:GetFeature>

I turned on verbose logging and tracked the logic down to the oracle
spatial plugin.

"28 May 16:39:43 DEBUG [data.oracle] - About to create Geometry
convertor for FEATURE_NAME.SHAPE"

I'd like to step through the source to try and understand what might
be different about the 2 "bad" rows versus the others, but I have no
clue where to obtain the source code.  Any advice on source code
location or possible solutions to the problem at hand would be
appreciated.

Thanks!
Sarah

-------- Original Message --------
Subject: Re: [Geoserver-users] where can I find gt-oracle-spatial-2.5.5.jar     
source code?
Date: Fri, 29 May 2009 21:20:13 +0800
From: Sarah Haskins <...>
To: geoserver-users ...

I figured it out.  Those 2 rows are of type Compound Line String (as
indicated by the Elem Info returned from Oracle).  According to
ETYPE.java and the SDO.java, this type (ETYPE.COMPOUND) is not
supported.  Makes sense, but I wish there'd been some logging to
indicate it was skipping my geometry.  If the same rules apply to NG,
it'd be great to include that logging.

Thanks for helping me find the source so I could figure this out.

{code}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises 
looking to deploy the next generation of Solaris that includes the latest 
innovations from Sun and the OpenSource community. Download a copy and 
enjoy capabilities such as Networking, Storage and Virtualization. 
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to