Comments inline. Andrea Aime wrote: > Hi, > looking into some complaints (some in jira, some others in private > mails) about Oracle NG not being able to deal with tables with > BLOBS or other unsupported types I noticed that in fact the old > JDBC and new JDBC datastores have different behaviour that > can be perceived as a regression from a user point of view: > - the old datastores just ignored columns they could not recognize, > see JDBC1DataStore line 1203-1215 > - the new datastores throw a solid exception instead Indeed, agreed it is a regression. > > This means people upgrading will see working tables not working > anymore due to unrecognized types. > I think the previous behavior was preferable, thought I would > log the fact the column is ignored at a higher level than FINER > (warning seems more appropriate). +1 > > Alternatively, the behavior could be user controlled, and have > a "ignore unrecognized columns" flag that is enabled by default. > Not against it, but don't see much of a gain, especially since we will be changing the default.
> One thing that the old datastores did not get fully right was > the relationship between ignoring a column and making the feature > type read only: if the ignored column is not nullable and it > has no default value, write operations will fail. > It would be better to set up a flag in that case that makes > the JDBCDataStore return a feature source in that case. Why the flag and not just do it anyways? IE: * if an unrecognized column that is nullable -> feature store * if an unrecognized column that is not nullable -> feature source > > Anyways, this is less critical, I think it would be better to > solve the above regression part before releasing GeoServer 1.7.6 > instead given it's (rightfully imho) perceived as a regression > from the users pov (it makes NG datastore not a drop in replacement > for old ones). Agreed. If you want to cook up a patch I will be happy to review asap before 1.7.6. > > Cheers > Andrea > -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. ------------------------------------------------------------------------------ Enter the BlackBerry Developer Challenge This is your chance to win up to $100,000 in prizes! For a limited time, vendors submitting new applications to BlackBerry App World(TM) will have the opportunity to enter the BlackBerry Developer Challenge. See full prize details at: http://p.sf.net/sfu/Challenge _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
