[ 
http://jira.codehaus.org/browse/GEOT-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christian Mueller reopened GEOT-2635:
-------------------------------------


Problem on 2.5.x , method declaration in SQLDialect

    public final Geometry decodeGeometryValue(GeometryDescriptor descriptor, 
ResultSet rs,
        int column, GeometryFactory factory, Connection cx ) throws 
IOException, SQLException {

Since this is a final declaration, OracleDialect does not compile


> PostgisNG and Oracle NG are using access by name instead of positional access 
> ------------------------------------------------------------------------------
>
>                 Key: GEOT-2635
>                 URL: http://jira.codehaus.org/browse/GEOT-2635
>             Project: GeoTools
>          Issue Type: Improvement
>          Components: data jdbc-ng
>    Affects Versions: 2.6-M1
>            Reporter: Andrea Aime
>            Assignee: Andrea Aime
>             Fix For: 2.5.8, 2.6-M2
>
>
> The thing is annoying especially because the datastore code assumes 
> positional access, and the dialect base class relays positional to named when 
> the positional is not implemented in the dialect.
> Unfortunalely both dialects forget to implement:
> public Geometry decodeGeometryValue(GeometryDescriptor descriptor, ResultSet 
> rs, int column,   GeometryFactory factory, Connection cx) 
> and do implement 
> public Geometry decodeGeometryValue(GeometryDescriptor descriptor, ResultSet 
> rs, String column,   GeometryFactory factory, Connection cx) 
> instead. Other dialects might be affected as well. I guess we should 
> deprecate the named access and end up using the positional access only

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to