Jody Garnett wrote: > Okay a bit more details now that I have done this process by hand for > DB2 and Oracle. > > In each case I copied: > - JDBCDataStoreFactory.createDataSource(params, dialect)) > > And inlined the following method to make it one complete bundle. > - getJDBCUrl( params ) > > So option (a) with this in mind: > - public BasicDataSource OracleNGDataStoreFactory.createDataSource( params ) > - I would not need the dialect as it is just used to control if prepared > statements are pooled > - the Existing createDataSoruce(params,dialect) method can remain > protected; and make use of the above BasicDataSource
Should be no problem to make the public method. Can you open a jira for this. > > However I am not sure how the BasicDataSource / DBCPDataSource is > managed. I think for my purpose I could work with just the BasicDataSource? > Not sure exactly what you mean. Why would it matter. Can you not just go through the javax.sql.DataSource interface? > Jody > > > > On 10/08/2009, at 3:22 PM, Jody Garnett wrote: > >> I am wading into the udig code changing over to the jdbc-ng >> implementations. And I have run into an interesting need; some of the >> wizard pages want to make use of a Connection in order to ask a few >> questions as they walk users through the process of setting up a >> datastore. >> >> The difficulty is the only code I can get a good connection from is >> private in JDBCDataStoreFactory.createDataSource( params, dialect). >> The dialect is only used here to figure out if >> setPoolPreparedStatements should be set to true. Then the whole mess >> is wrapped up in a DBCPDataSource before being returned. >> >> For today i am going to have to just cut and paste code; but I should >> ask if: >> a) this code can be factored out or otherwise made visible >> b) are we going to allow applications to choose between DBCP and C3PO? >> This is a repeat of Andrea's question from last week. >> >> jody > > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------------ > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day > trial. Simplify your report design, integration and deployment - and focus on > what you do best, core application coding. Discover what's new with > Crystal Reports now. http://p.sf.net/sfu/bobj-july > > > ------------------------------------------------------------------------ > > _______________________________________________ > Geotools-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
