I got NullPointerExceptions creating a new WPSFactory. The first one 
happens in org.geotools.data.wps.WPSFactory:
private void buildValuesFromProcessDescriptionType():

this.description = this.pdt.getAbstract().getValue();

In net.opengis.wps10.impl.DescriptionTypeImpl getAbstract() returns 
_abstract and I cannot see any checks that avoid returning null. Trying 
.getValue() results in the NPE. Since the child element "ows:Abstract" 
of "DescriptionType" is optional 
(http://schemas.opengis.net/wps/1.0.0/common/DescriptionType.xsd) it 
must be checked if null is returned or not. Like

this.description = 
this.pdt.getAbstract()==null?"":this.pdt.getAbstract().getValue();

It's not up to me to decide whether an empty String "" or null for 
this.description should be used. Using null will result in an 
IllegalArgumentException in getDescription() during conversion into an 
InternationalString object.


The same problem in org.geotools.data.wps.WPSUtils twice:

1) createInputParamMap(..)
Creating the new Parameter
Parameter param = new Parameter(idt.getIdentifier().getValue(), type,
                     Text.text(idt.getTitle().getValue()),
                     Text.text(idt.getAbstract().getValue()), required,
                     idt.getMinOccurs().intValue(), 
idt.getMaxOccurs().intValue(),
                     null, null);

2) createOutputParamMap(..)
  Parameter param = new Parameter(odt.getIdentifier().getValue(), type,
                     Text.text(odt.getTitle().getValue()),
                     Text.text(odt.getAbstract().getValue()) );


Cheers, Matthias

-- 
Matthias Lendholt [matthias.lendh...@gfz-potsdam.de]
tel: +49 331 288 1687; fax: +49 331 288 1703
Deutsches GeoForschungsZentrum (GFZ)
Telegrafenberg A20; D14473 Potsdam; Germany

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to