Gabriel Roldan ha scritto:
> Andrea Aime wrote:
>> Gabriel Roldan ha scritto:
>>> Andrea Aime wrote:
>>>> Gabriel Roldan ha scritto:
>>>>> I know why it doesn't work, FastBBOX is tricky, it defeats the
>>>>> purpose of DuplicatingFilterVisitor:
>>>>>
>>>>> public Object accept(FilterVisitor visitor, Object context) {
>>>>> Object result = visitor.visit(this, context);
>>>>> if(!(result instanceof BBOX))
>>>>> return result;
>>>>>
>>>>> BBOX clone = (BBOX) result;
>>>>> if(clone.getExpression1().equals(getExpression1()) &&
>>>>> clone.getExpression2().equals(getExpression2()))
>>>>> return new FastBBOX(property, envelope);
>>>>>
>>>>> return result;
>>>>> }
>>>>
>>>> It does not defeat the purpose at all imho.
>>>> A duplicate of a FastBbox is another FastBBOX.
>>>> We're asked to copy, not to transform
>>> I think it does because one would expect the returning filter to be
>>> created by the FilterFactory set in the DuplicatingFilterVisitor, if
>>> one wants the equivalent filter with an specific implementation.
>>> Anyways, I'm going to hack on WFSDataStore.
>>
>> Hmm... duplicating that way would break the very reason the FastBBOX
>> has been created for: avoiding full topologic operations.
>> Unfortunately just creating it in the renderer does not help,
>> there are various copies on the road to actual data access...
>>
>> The better way would be to have the library recognize loose bbox
>> as a legitimate use case, but that required more time than I had,
>> was planning to start pushing on that after FOSS4G
> understood and agreed, hence I prefer a hack on WFSDataStore. Agreed?
Works for me :)
Cheers
Andrea
--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
