Gabriel Roldan ha scritto:
> Hi all,
> 
> first off, sorry for cross posting.
> 
> the following is a patch for CommonFactoryFinder for which I'd like a 
> review/comments/concerns/permission to commit: 
> <http://pastebin.com/m3b046ebc>
> 
> The thing is that on a geoserver WMS profiling session, the 
> getFilterFactory method is used by every request and being synchronized 
> makes the threads block unnecesarily.
> Now, all the getXXX methods seem to be synchronized only for the 
> getServiceRegistry() method they call, which seems to be better done if 
> synchronizing only the block of getServiceRegistry() that instantiates 
> the registry itself. But I might be missing something... comments?

Made the same question time ago:
http://n2.nabble.com/Common-factory-finder-synchronization-and-caching-td1948914.html#a1948914

Long story short, SPI lookups are so involved that even just a scan 
through them mutates the state of the registry. Sigh...

Cheers
Andrea

-- 
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to