Hi all,
I have been working on being able to properly generate the wcs emf model
as described in a previous email. I believe I have things working again.
Here is a summary of what I have done.
The main problem was that after the original model generation from xml
schema changes to model were made without keeping the wcs10.genmodel in
sync. So what I did was rolled back the manual changes and then remade
the changes step by step keeping the genmodel in sync.
I believe i have maintained all the original changes. There is one issue
though I was not sure on. In org.opengis.gml.RectifiedGridType a setter
for the "offsetVector" property was added:
public void setOffsetVector(List offsetVector) {
if (this.offsetVector == null)
offsetVector = new
EObjectContainmentEList(VectorType.class, this,
Gml4wcsPackage.RECTIFIED_GRID_TYPE__OFFSET_VECTOR);
this.offsetVector.clear();
for (Object o : offsetVector) {
this.offsetVector.add(o);
}
}
Which essentially clears the list and adds back to it. I wonder if it is
just ok to leave this off? It does not actually seemed to be used. After
removing it and running full builds of geotools and geoserver there are
no compile or test errors. So I assume we can leave it off?
Another problem that emf had was with the gml model used by the wcs10
model. In some places the model was refered to as "gml" (like in the
package) and in others it was referred to as "gml4wcs". So I changed all
references to just gml. And it works ok. However this did result in some
compile errors due to Gml4wcsFactory no longer being around. But I
manually added the interface which extends the now GmlFactory and that
fixed all broken code.
Any objections to comitting my fixes? Unfortunately the patch for the
changes is massive because i had to regenerate fully the wcs10 and gml
models, so there is a ton of changes in the patch. But I can post the
patch if people wish.
Also to prevent further issues it would be nice if we could stay way
from making manual changes to the emf model without keeping the genmodel
in sync. That said i am well aware that EMF is scary and people have
issues using it. So I have tried to write up an EMF reference guide of
sorts which describes how to go about safely instrumenting generated EMF
models:
http://docs.codehaus.org/display/GEOT/Eclipse+Modeling+Framework
-Justin
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
