Milton Jonathan ha scritto:
> Hello again Andrea
> 
> OK, took me a while to find the time, but finally I reviewed your patch.

Took me a while to act, but the patch is not committed on both 2.6.x
and trunk. Thanks a ton for the contribution, looking for more.
Speaking of more, what about that factory that generates hatches at any
angle? I would like to merge it with the shapes://xyz one

> First of all, great work! Everything works (almost) perfectly! There are 
> only two small issues that I've noticed:
> 
> 1. I found out you forgot to include a line in ShapefileRenderer's 
> StyledShapePainter.paint(): when dealing with GraphicStyle2D, you forgot 
> a "iter.next()" call, which ended up causing an infinite loop for point 
> styles using SVGs (should place that call at line 185). If you think 
> it's worth it, I am sending you a "reviewed" patch after applying yours 
> to 2.6.1 and adding just that line..

Fix included

> 2. Probably not having anything to do with these changes, I found out 
> that the SVGs are no longer drawn with antialiasing (no matter with or 
> without vector rendering). I would guess this is something that changed 
> from 2.6.0 to 2.6.1, but is there a way to turn it on? A rendering hint 
> maybe?

I added the antialiasing hint to the rasterization code but not
sure if that improved things a lot. Can you double check?

Cheer
Andrea

-- 
Andrea Aime
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.


------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to