Justin Deoliveira ha scritto:
> Hi Rini,
>
> I see your point. And off the top of my head I can't think of any
> specific reason for that behavior. That said I would be a little weary
> of changing it as I am guessing it was done for some reason that is
> escaping me at the moment.
>
> I am open to changing it but I think we would want to do a good set of
> regression testing if we do.
svn blame points at me for that line of code with a rather unhelpful
commit log:
-----------------------------------------------------------------------
r27215 | aaime | 2007-09-29 18:57:30 +0200 (sab, 29 set 2007) | 1 line
Yay, filter switched and test passing
-----------------------------------------------------------------------
However the date is telling a lot: that day we were doing the code
sprint at Refractions Research after FOSS4G 2007, which is when we
switched the code base to the new model.
Lots of search and replace without much thinking, and the line of
code before my modification was:
if ( object instanceof Feature ) {
return ((Feature) object).getAttribute( xpath ) != null;
}
It seems to me the meaning was maintained, as the old Feature
class was a pure simple feature.
However, I don't think there were many other property accessors
at the time and probably not finding any property accessor the
code ended up returning null anyways? Not sure...
Cheers
Andrea
--
Andrea Aime
OpenGeo - http://opengeo.org
Expert service straight from the developers.
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
